Attention is currently required from: pespin. dexter has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/upf-benchmark/+/39421?usp=email )
Change subject: osmo-upf-load-gen: Add vty cmd to skip binding local GTPU ports ...................................................................... Patch Set 1: Code-Review+1 (3 comments) Patchset: PS1: Didn't see any real problems here. I think this patch should be fine. File src/osmo-upf-load-gen/pfcp_tool.c: https://gerrit.osmocom.org/c/upf-benchmark/+/39421/comment/a0e23805_9ce1e7ad?usp=email : PS1, Line 260: static Maybe make this function static in a patch before this one? https://gerrit.osmocom.org/c/upf-benchmark/+/39421/comment/31263be9_3211696c?usp=email : PS1, Line 306: { Maybe make this function static in a different patch? -- To view, visit https://gerrit.osmocom.org/c/upf-benchmark/+/39421?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: upf-benchmark Gerrit-Branch: master Gerrit-Change-Id: Idc6e013d6c7de24889bc500625707c5b5cc1766b Gerrit-Change-Number: 39421 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Comment-Date: Tue, 28 Jan 2025 08:57:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes
