Attention is currently required from: lynxis lazus.

pespin has posted comments on this change by lynxis lazus. ( 
https://gerrit.osmocom.org/c/osmo-sgsn/+/39247?usp=email )

Change subject: gprs_gmm_util: use a RAU specific TLV dictionary
......................................................................


Patch Set 2: Code-Review+2

(1 comment)

File src/sgsn/gprs_gmm_util.c:

https://gerrit.osmocom.org/c/osmo-sgsn/+/39247/comment/cb70b890_1d2b228b?usp=email
 :
PS1, Line 265:  ret = tlv_parse(&rau_req->tlv, &gsm48_gmm_rau_ie_tlvdef,
> I'm not sure if osmo_tlv_prot_def is a big help here. […]
Fine, just wanted to share in case you wanted to have a look.



--
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/39247?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: I460971deeebc9977a984937c542b263d941e78df
Gerrit-Change-Number: 39247
Gerrit-PatchSet: 2
Gerrit-Owner: lynxis lazus <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Reviewer: pespin <[email protected]>
Gerrit-Attention: lynxis lazus <[email protected]>
Gerrit-Comment-Date: Tue, 28 Jan 2025 10:48:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: pespin <[email protected]>
Comment-In-Reply-To: lynxis lazus <[email protected]>

Reply via email to