Attention is currently required from: fixeria, lynxis lazus.

dotsimon has posted comments on this change by dotsimon. ( 
https://gerrit.osmocom.org/c/osmo-msc/+/39428?usp=email )

Change subject: Include SM-RP-UI in outgoing GSUP message when presesnt
......................................................................


Patch Set 4:

(3 comments)

File include/osmocom/msc/gsm_04_11_gsup.h:

https://gerrit.osmocom.org/c/osmo-msc/+/39428/comment/d8972fa0_a1e583cd?usp=email
 :
PS3, Line 15: uint8_t *ui_buf
> `const`
Done


https://gerrit.osmocom.org/c/osmo-msc/+/39428/comment/b702a981_011805e2?usp=email
 :
PS3, Line 15: uint8_t ui_len, uint8_t *ui_buf
> To keep it consistent with existing API (e.g. […]
No worries


https://gerrit.osmocom.org/c/osmo-msc/+/39428/comment/aeebe9dd_aa7c5fe6?usp=email
 :
PS3, Line 17: uint8_t *ui_buf
> `const`
Done



--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/39428?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I90a607900ac7c86b200c79b7e8c460d4cbb3c3ce
Gerrit-Change-Number: 39428
Gerrit-PatchSet: 4
Gerrit-Owner: dotsimon <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <[email protected]>
Gerrit-Reviewer: lynxis lazus <[email protected]>
Gerrit-CC: pespin <[email protected]>
Gerrit-Attention: fixeria <[email protected]>
Gerrit-Attention: lynxis lazus <[email protected]>
Gerrit-Comment-Date: Thu, 30 Jan 2025 17:55:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <[email protected]>

Reply via email to