Attention is currently required from: csaba.sipos, laforge.

pespin has posted comments on this change by csaba.sipos. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/39416?usp=email )

Change subject: nokia_site: Add object_identity, object_state and 
object_identity_state attributes
......................................................................


Patch Set 21:

(1 comment)

File src/osmo-bsc/bts_nokia_site.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/39416/comment/4378a375_ac456d6b?usp=email
 :
PS21, Line 1860:                        !FIND_ELEM(noh->data, len_data, 
NOKIA_EI_OBJ_STATE, &object_state, sizeof(object_state))) {
> Sounds like you are using a different indentation config, ie 1 tab = 4 spaces 
> vs 1 tab = 8 spaces. […]
BTW, FYI, in general in if the column doesn't fit exactly at the tab boundary, 
you need to add some space chars to move the code a bit more to the right.



--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/39416?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Id9f819b0649ba3c247db72d7d738e49c72388dc3
Gerrit-Change-Number: 39416
Gerrit-PatchSet: 21
Gerrit-Owner: csaba.sipos <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Reviewer: pespin <[email protected]>
Gerrit-CC: domi <[email protected]>
Gerrit-Attention: csaba.sipos <[email protected]>
Gerrit-Attention: laforge <[email protected]>
Gerrit-Comment-Date: Mon, 10 Feb 2025 17:49:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: csaba.sipos <[email protected]>
Comment-In-Reply-To: pespin <[email protected]>

Reply via email to