Attention is currently required from: osmith.

fixeria has posted comments on this change by osmith. ( 
https://gerrit.osmocom.org/c/libosmocore/+/39418?usp=email )

Change subject: utils/osmo-install-dbg-pkgs: new script
......................................................................


Patch Set 2: Code-Review+1

(2 comments)

File utils/osmo-install-dbg-pkgs.py:

https://gerrit.osmocom.org/c/libosmocore/+/39418/comment/3c02a66d_6896e0e6?usp=email
 :
PS2, Line 64: package.startswith("osmo-") or package.startswith("libosmo"):
This would not match packages like `libasn1c`, `libgtpnl`, `libsmpp34`, `gapk`.


https://gerrit.osmocom.org/c/libosmocore/+/39418/comment/7ea75d80_f7c74880?usp=email
 :
PS2, Line 142: main()
`if __name__ == '__main__':`?



--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/39418?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I903cef0a3e358701d14dcf1980fe0f8d5d5b4d62
Gerrit-Change-Number: 39418
Gerrit-PatchSet: 2
Gerrit-Owner: osmith <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <[email protected]>
Gerrit-Reviewer: pespin <[email protected]>
Gerrit-Attention: osmith <[email protected]>
Gerrit-Comment-Date: Mon, 10 Feb 2025 18:01:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes

Reply via email to