osmith has submitted this change. (
https://gerrit.osmocom.org/c/osmo-sgsn/+/39543?usp=email )
Change subject: vty: Avoid accessing gsupclient object fields directly
......................................................................
vty: Avoid accessing gsupclient object fields directly
Use new APIs recently added.
Depends: osmo-hlr.git Change-Id I401af83232022f1c141eef1f428cbe206a8aaaa2
Change-Id: Ie443ef0bd983635a5b29e434d79b93ef3f7ce370
(cherry picked from commit 6668b2b29a5c1e8b7a22c66df95795485e204a8a)
---
M TODO-RELEASE
M src/sgsn/sgsn_vty.c
2 files changed, 5 insertions(+), 5 deletions(-)
Approvals:
pespin: Looks good to me, approved
Jenkins Builder: Verified
diff --git a/TODO-RELEASE b/TODO-RELEASE
index eb1cdfd..02149e5 100644
--- a/TODO-RELEASE
+++ b/TODO-RELEASE
@@ -9,3 +9,4 @@
#library what description / commit summary line
libgtp >1.12.0 new field dir_tun_flags in struct pdp_t
libgtp >1.12.0 gtp_set_cb_update_context_ind(), gtp_update_context_resp()
+libosmo-gsup-client >1.8.0 osmo_gsup_client_is_connected(),
osmo_gsup_client_get_rem_addr(), osmo_gsup_client_get_rem_port()
diff --git a/src/sgsn/sgsn_vty.c b/src/sgsn/sgsn_vty.c
index bcb8dc2..113fdd1 100644
--- a/src/sgsn/sgsn_vty.c
+++ b/src/sgsn/sgsn_vty.c
@@ -669,11 +669,10 @@
SHOW_STR "Display information about the SGSN")
{
if (sgsn->gsup_client) {
- struct ipa_client_conn *link = sgsn->gsup_client->link;
- vty_out(vty,
- " Remote authorization: %sconnected to %s:%d via
GSUP%s",
- sgsn->gsup_client->is_connected ? "" : "not ",
- link->addr, link->port,
+ vty_out(vty, " Remote authorization: %sconnected to %s:%d via
GSUP%s",
+ osmo_gsup_client_is_connected(sgsn->gsup_client) ? "" :
"not ",
+ osmo_gsup_client_get_rem_addr(sgsn->gsup_client),
+ osmo_gsup_client_get_rem_port(sgsn->gsup_client),
VTY_NEWLINE);
}
if (sgsn->gsn)
--
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/39543?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: osmo-sgsn
Gerrit-Branch: pespin/base
Gerrit-Change-Id: Ie443ef0bd983635a5b29e434d79b93ef3f7ce370
Gerrit-Change-Number: 39543
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <[email protected]>
Gerrit-Reviewer: pespin <[email protected]>
