pespin has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39619?usp=email )
Change subject: stp: Fix expectancies of TC_clnt_quirk_snm_inactive
......................................................................
stp: Fix expectancies of TC_clnt_quirk_snm_inactive
The test STP_Tests_M3UA.TC_clnt_quirk_snm_inactive validates the
snm_inactive quirk by sending a DAUD before the link being activated,
and expecting a DAVA to make sure osmo-stp did indeed process the SNM
message.
However, osmo-stp used to lack proper route validation based on link
state, which means it would incorrectly assumed the link for the
affected PC (55) in the test was active and hence would answer with a
DAVA. After libosmo-sigtran.git Change-Id
I928fb1ef5db6922f1386a188e3fbf9e70780f25d this wrong behavior is fixed,
and hence osmo-stp starts answering with a DUNA instead of a DAVA, since
AS "as-client" has not yet been activated during the test.
Fix the test expectancies by expecting a DUNA instead of a DAVA.
Change-Id: I907981c1487b299df852c405bae1fefff4bf5191
Depends: libosmo-sigtran.git Change-Id I928fb1ef5db6922f1386a188e3fbf9e70780f25d
Related: SYS#7112
---
M stp/STP_Tests_M3UA.ttcn
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks
refs/changes/19/39619/1
diff --git a/stp/STP_Tests_M3UA.ttcn b/stp/STP_Tests_M3UA.ttcn
index 0ae854b..ce67e98 100644
--- a/stp/STP_Tests_M3UA.ttcn
+++ b/stp/STP_Tests_M3UA.ttcn
@@ -1179,7 +1179,7 @@
var template (value) M3UA_Point_Codes aff_pcs := {
ts_M3UA_PC(f_m3ua_srv_config(0).point_code) };
f_M3UA_send(M3UA_SRV(0), ts_M3UA_DAUD(aff_pcs));
- f_M3UA_exp(M3UA_SRV(0), tr_M3UA_DAVA(aff_pcs));
+ f_M3UA_exp(M3UA_SRV(0), tr_M3UA_DUNA(aff_pcs));
setverdict(pass);
f_no_quirk("no_notify");
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39619?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I907981c1487b299df852c405bae1fefff4bf5191
Gerrit-Change-Number: 39619
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pes...@sysmocom.de>
