Attention is currently required from: falconia.

pespin has posted comments on this change by falconia. ( 
https://gerrit.osmocom.org/c/libosmo-abis/+/39626?usp=email )

Change subject: rtp2trau HR to DL: validate ToC octet of RFC 5993
......................................................................


Patch Set 1: Code-Review+1

(1 comment)

File src/trau/trau_rtp_conv.c:

https://gerrit.osmocom.org/c/libosmo-abis/+/39626/comment/12449915_367320f9?usp=email
 :
PS1, Line 671:          if (data[0] & 0xD0)
Having a bitmask of defines here would be a lot clearer.



--
To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/39626?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-Change-Id: Ibbaa1e1e12254eaf75a999dd1b58e2145eff158c
Gerrit-Change-Number: 39626
Gerrit-PatchSet: 1
Gerrit-Owner: falconia <fal...@freecalypso.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pes...@sysmocom.de>
Gerrit-Attention: falconia <fal...@freecalypso.org>
Gerrit-Comment-Date: Wed, 26 Feb 2025 12:25:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes

Reply via email to