Attention is currently required from: daniel, fixeria, pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39641?usp=email )
Change subject: stp: Allow setting up different m3ua_config list by test ...................................................................... Patch Set 1: Code-Review+1 (2 comments) File stp/STP_Tests_M3UA.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39641/comment/04d47446_1bee8bb0?usp=email : PS1, Line 47: /* Clients first, servers afterwards, match mp_m3ua_num_{clients,servers} */ maybe add an explicit check for this? https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39641/comment/d9d81c29_1b9f6626?usp=email : PS1, Line 135: g_m3ua_num_clients is _clients correct here, or should it be _servers? -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39641?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I0a875bac5e9506be9140d5afa28da25bdc99a5a6 Gerrit-Change-Number: 39641 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pes...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillm...@sysmocom.de> Gerrit-Reviewer: fixeria <vyanits...@sysmocom.de> Gerrit-Reviewer: laforge <lafo...@osmocom.org> Gerrit-Reviewer: osmith <osm...@sysmocom.de> Gerrit-Attention: pespin <pes...@sysmocom.de> Gerrit-Attention: fixeria <vyanits...@sysmocom.de> Gerrit-Attention: daniel <dwillm...@sysmocom.de> Gerrit-Comment-Date: Fri, 28 Feb 2025 09:00:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes
