Attention is currently required from: daniel.

pespin has posted comments on this change by pespin. ( 
https://gerrit.osmocom.org/c/libosmo-sigtran/+/39406?usp=email )

Change subject: AS loadsharing: Introduce AS rate_ctr rx:msu:sls:*
......................................................................


Patch Set 8:

(1 comment)

File src/m3ua.c:

https://gerrit.osmocom.org/c/libosmo-sigtran/+/39406/comment/86a8db1e_a01a9cfb?usp=email
 :
PS8, Line 620:  rate_ctr_inc2(as->ctrg, SS7_AS_CTR_RX_MSU_SLS_0 + xua->mtp.sls);
> Is xua->mtp.sls <= 0x0f already guaranteed here? Same in sua. […]
It should, but I agree it makes sense to add an ASSERT.



--
To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/39406?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: I695bd3933a116323db45ab7f45dcf539791139aa
Gerrit-Change-Number: 39406
Gerrit-PatchSet: 8
Gerrit-Owner: pespin <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Reviewer: osmith <[email protected]>
Gerrit-CC: daniel <[email protected]>
Gerrit-Attention: daniel <[email protected]>
Gerrit-Comment-Date: Tue, 04 Mar 2025 16:14:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: daniel <[email protected]>

Reply via email to