Attention is currently required from: laforge.

pespin has posted comments on this change by pespin. ( 
https://gerrit.osmocom.org/c/libosmo-sigtran/+/39391?usp=email )

Change subject: AS loadsharing: Implement AS loadshare, skip unavailable 
AS/lset when choosing
......................................................................


Patch Set 10:

(1 comment)

File src/ss7_combined_linkset.h:

https://gerrit.osmocom.org/c/libosmo-sigtran/+/39391/comment/0e2adc64_c87d0ca7?usp=email
 :
PS10, Line 36: last_route_roundrobin
> don't you need to somehow guard against this pointer becoming stale if the 
> route it points to is rem […]
Yes, good catch, I thought I had done this but I apparently forgot 😊



--
To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/39391?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: I928fb1ef5db6922f1386a188e3fbf9e70780f25d
Gerrit-Change-Number: 39391
Gerrit-PatchSet: 10
Gerrit-Owner: pespin <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <[email protected]>
Gerrit-CC: laforge <[email protected]>
Gerrit-Attention: laforge <[email protected]>
Gerrit-Comment-Date: Wed, 05 Mar 2025 13:31:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <[email protected]>

Reply via email to