Patch Set 1: (2 comments)
https://gerrit.osmocom.org/#/c/6211/1/src/libbsc/abis_rsl.c File src/libbsc/abis_rsl.c: Line 1791: /* Set all request references and wait indications to the same value. > it might make sense to state explicitly here that the spec requires entries I'll add a reference to the spec I read in the next patchset. https://gerrit.osmocom.org/#/c/6211/1/src/libbsc/net_init.c File src/libbsc/net_init.c: Line 79: osmo_timer_setup(&net->t3122_chan_load_timer, update_t3122_chan_load_timer, net); > I think it might make sense to have each BTS have its own timer, rather tha I'll add a comment in the next patch set. -- To view, visit https://gerrit.osmocom.org/6211 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I57e38f6d6ba3b23cc6e1f9520b90261dbb1f1cec Gerrit-PatchSet: 1 Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Owner: Stefan Sperling <ssperl...@sysmocom.de> Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Stefan Sperling <ssperl...@sysmocom.de> Gerrit-HasComments: Yes
