Attention is currently required from: laforge. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/39377?usp=email )
Change subject: AS loadsharing: Initial routing implementation based on extended-SLS ...................................................................... Patch Set 11: (1 comment) File include/osmocom/sigtran/osmo_ss7.h: https://gerrit.osmocom.org/c/libosmo-sigtran/+/39377/comment/c43f0a8e_b063ba3c?usp=email : PS11, Line 129: O > so basically an external application cannot look routes anymore? I'm not > saying it's critical, just […] This function becomes deprecated because anyway it doesn't take into account all the possible route-label fields, hence it's not really useful in the general scenario. Deprecating this one indeed leaves no "public" way of looking up routes, but I acknowledge this may be updated in follow-up patches once I have this tone, see previous comment https://gerrit.osmocom.org/c/libosmo-sigtran/+/39377/4/include/osmocom/sigtran/osmo_ss7.h#129 which contains further explanation. I prefer now to have this private and once I look into the specific IPA scenario from osmo-bsc I mention in the comment see what's the best set of APIs to expose. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/39377?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I0fb4ca4959096f748a23082efa0481300de56436 Gerrit-Change-Number: 39377 Gerrit-PatchSet: 11 Gerrit-Owner: pespin <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: osmith <[email protected]> Gerrit-Attention: laforge <[email protected]> Gerrit-Comment-Date: Wed, 05 Mar 2025 14:57:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <[email protected]>
