Attention is currently required from: fixeria. neels has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/pysim/+/39742?usp=email )
Change subject: [2/7] personalization: refactor ConfigurableParameter, Iccid, Imsi ...................................................................... Patch Set 4: (2 comments) File pySim/esim/saip/personalization.py: https://gerrit.osmocom.org/c/pysim/+/39742/comment/02568da7_49ca10eb?usp=email : PS4, Line 40: This class is abstract, you will only use subclasses in practice. > This is exactly what `abc.ABC` is for. […] (let's keep one of the two conversations; closing this one) https://gerrit.osmocom.org/c/pysim/+/39742/comment/c0e6db77_0254e4db?usp=email : PS4, Line 42: Subclasses have to implement the apply_val() classmethods > ... and this would have been obvious if you just defined it as follows: […] when i tried to detect whether a class is abstract, it didn't work. I think i tried introspect.isabstract() or similar. There is no need to enforce the abstractness. It's fine to call the abstract method, even. it is only "semantically" abstract, not in the strict language sense, like in C++ where a function pointer is actually NULL. In the code I'm working with, there are tons of abstract methods, but i see no abc. If I don't need enforcing, it doesn't work as is_abstract(), and i can just write "abstract" in the comment, then i can reduce this code cruft without any disadvantage. right? -- To view, visit https://gerrit.osmocom.org/c/pysim/+/39742?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I6522be4c463e34897ca9bff2309b3706a88b3ce8 Gerrit-Change-Number: 39742 Gerrit-PatchSet: 4 Gerrit-Owner: neels <nhofm...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanits...@sysmocom.de> Gerrit-Attention: fixeria <vyanits...@sysmocom.de> Gerrit-Comment-Date: Mon, 10 Mar 2025 11:59:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanits...@sysmocom.de>
