Attention is currently required from: fixeria.

neels has posted comments on this change by neels. ( 
https://gerrit.osmocom.org/c/pysim/+/39741?usp=email )

Change subject: [1/7] personalization: refactor: drop ClassVarMeta use
......................................................................


Patch Set 5:

(1 comment)

File pySim/esim/saip/personalization.py:

https://gerrit.osmocom.org/c/pysim/+/39741/comment/a389e38b_aaeb18f3?usp=email :
PS4, Line 61: @abc.abstractmethod
> i commented on this on the subsequent commit, TL;DR: no noticeable difference 
> and no need to have it […]
@abc.abstractmethod is back



--
To view, visit https://gerrit.osmocom.org/c/pysim/+/39741?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I60ea8fd11fb438ec90ddb08b17b658cbb789c051
Gerrit-Change-Number: 39741
Gerrit-PatchSet: 5
Gerrit-Owner: neels <nhofm...@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <vyanits...@sysmocom.de>
Gerrit-Attention: fixeria <vyanits...@sysmocom.de>
Gerrit-Comment-Date: Mon, 10 Mar 2025 13:01:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels <nhofm...@sysmocom.de>
Comment-In-Reply-To: fixeria <vyanits...@sysmocom.de>

Reply via email to