Attention is currently required from: Hoernchen, laforge. osmith has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39470?usp=email )
Change subject: clang-format ...................................................................... Patch Set 3: Code-Review+1 (2 comments) Patchset: PS2: > I'd say this needs some more explanation and possibly integration? What is > the purpose of the file? […] * pre-commit hook is there now * server side: needs clang-format added to the docker container first: https://gerrit.osmocom.org/c/docker-playground/+/39763, I can adjust contrib/jenkins.sh in a follow-up patch after both are merged so we don't need to block here File contrib/pre-commit-hook: https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39470/comment/562950a5_998dabdb?usp=email : PS3, Line 1: #!/usr/bin/env bash maybe make this executable? -- To view, visit https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39470?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-asf4-dfu Gerrit-Branch: master Gerrit-Change-Id: I9768bc2590ca5306ee19d3276f0953c6b0b6f926 Gerrit-Change-Number: 39470 Gerrit-PatchSet: 3 Gerrit-Owner: Hoernchen <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: osmith <[email protected]> Gerrit-Attention: Hoernchen <[email protected]> Gerrit-Attention: laforge <[email protected]> Gerrit-Comment-Date: Tue, 11 Mar 2025 07:33:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: laforge <[email protected]>
