Attention is currently required from: dexter.

laforge has posted comments on this change by dexter. ( 
https://gerrit.osmocom.org/c/pysim/+/39670?usp=email )

Change subject: filesystem: do not decode short TransRecEF records
......................................................................


Patch Set 3: Code-Review+2

(1 comment)

File pySim/filesystem.py:

https://gerrit.osmocom.org/c/pysim/+/39670/comment/2f843a43_beccc0bd?usp=email :
PS3, Line 1231:         if len(raw_hex_data) // 2 < self.__get_rec_len():
> I think I don't get what you mean by that. The too-short trailer is output as 
> raw data (e.g. […]
Done



--
To view, visit https://gerrit.osmocom.org/c/pysim/+/39670?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Ib1dc4d7ce306f1f0b080bb4b6abc36e72431d3fa
Gerrit-Change-Number: 39670
Gerrit-PatchSet: 3
Gerrit-Owner: dexter <pma...@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanits...@sysmocom.de>
Gerrit-Reviewer: laforge <lafo...@osmocom.org>
Gerrit-Attention: dexter <pma...@sysmocom.de>
Gerrit-Comment-Date: Mon, 10 Mar 2025 18:59:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: laforge <lafo...@osmocom.org>
Comment-In-Reply-To: dexter <pma...@sysmocom.de>

Reply via email to