Attention is currently required from: falconia, fixeria.
Hello Jenkins Builder, fixeria, laforge,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/libosmo-abis/+/39731?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Code-Review+1 by fixeria, Verified+1 by Jenkins Builder
Change subject: trau: new function osmo_trau2rtp_ufe()
......................................................................
trau: new function osmo_trau2rtp_ufe()
TRAU frame formats for newer codecs (HR, EFR, AMR) include a UFE
(uplink frame error) indicator bit in the DL direction. TRAUs are
expected to set this bit to active error state (0 for HR/EFR/AMR or
1 for D144 E-TRAU) if frame synchronization is lost in the UL
direction, or if received TRAU-UL frames have bad CRC or invalid
control bits - errors that indicate corruption on terrestrial
circuits or faults in the CCU, rather than radio Rx errors.
In Osmocom implementation, TRAU frame CRC and control bit patterns
are checked during conversion to RTP, as part of the work done by
osmo_trau2rtp() - but there is no separate return indication from
that function that distinguishes these errors from ordinary BFIs
due to radio errors or FACCH stealing etc. Solution: add a new
API function that indicates UFE conditions separately.
Related: OS#6614
Change-Id: I7a90eca296b17b1211e5c2125fb1496cd362e1c9
---
M include/osmocom/trau/trau_rtp.h
M src/trau/trau_rtp_conv.c
2 files changed, 89 insertions(+), 32 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/31/39731/2
--
To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/39731?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-Change-Id: I7a90eca296b17b1211e5c2125fb1496cd362e1c9
Gerrit-Change-Number: 39731
Gerrit-PatchSet: 2
Gerrit-Owner: falconia <fal...@freecalypso.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanits...@sysmocom.de>
Gerrit-Reviewer: laforge <lafo...@osmocom.org>
Gerrit-Attention: falconia <fal...@freecalypso.org>
Gerrit-Attention: fixeria <vyanits...@sysmocom.de>
