Patch Set 1: Code-Review-1 I agree with max that this is not our usual coding style.
As the definitions are rather regular, I would prefer a macro like GSM48_RACH_CTRL_ACC(N) or a related inline function. also, we can remove the RACH_CTRL part from it, as access control classes are a more general concept, and there's no risk conflicting any other 'access control classes' in the scope of GSM specs. -- To view, visit https://gerrit.osmocom.org/6286 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8f0a65c2980f86eb5c43f3bebe727f4d4d973163 Gerrit-PatchSet: 1 Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Owner: Stefan Sperling <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Max <[email protected]> Gerrit-Reviewer: Stefan Sperling <[email protected]> Gerrit-HasComments: No
