Attention is currently required from: fixeria, laforge.
neels has posted comments on this change by neels. (
https://gerrit.osmocom.org/c/pysim/+/39741?usp=email )
Change subject: [1/6] personalization: refactor: drop ClassVarMeta use
......................................................................
Patch Set 7:
(1 comment)
Patchset:
PS6:
> CSV matching: I have other use cases than you do. […]
In this new patch set, the name and camel_to_snake() are back (they were lost
by accident from branch rebasing).
reasons in my decision against a meta class:
- i don't understand what purpose a meta class serves.
- fixeria's example shows that the shortest way to achieve class attributes is
~~~
class Foo:
a = 1
b = 2
~~~
I like this plain python better than kwargs juggling.
- upcoming patches add a lot of class attributes, and i would like to
consistently use one way. I chose the "normal python" way, so as a first step,
this patch drops the meta class.
- name: i would like to set explicit names like 'IMSI' instead of 'imsi',
Hence i change to using an explicit 'name' attribute instead of getattr magic.
When no explicit name is set, all still behaves as before this patch.
I hope that I've made my point, so i am now, in a hopeful way, resolving this
thread.
Please -1 again if i should change it.
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/39741?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I60ea8fd11fb438ec90ddb08b17b658cbb789c051
Gerrit-Change-Number: 39741
Gerrit-PatchSet: 7
Gerrit-Owner: neels <nhofm...@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <vyanits...@sysmocom.de>
Gerrit-CC: laforge <lafo...@osmocom.org>
Gerrit-Attention: laforge <lafo...@osmocom.org>
Gerrit-Attention: fixeria <vyanits...@sysmocom.de>
Gerrit-Comment-Date: Sat, 19 Apr 2025 20:59:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels <nhofm...@sysmocom.de>
Comment-In-Reply-To: laforge <lafo...@osmocom.org>
Comment-In-Reply-To: fixeria <vyanits...@sysmocom.de>
