Attention is currently required from: laforge.

kirr has posted comments on this change by kirr. ( 
https://gerrit.osmocom.org/c/osmocom-bb/+/40055?usp=email )

Change subject: trx_toolkit/udp_link: Optimize UDPLink.send
......................................................................


Patch Set 2:

(1 comment)

Patchset:

PS2:
> just a random comment: As we do a lot of io_uring in libosmocore and programs 
> using it in recent tim […]
Harald, thanks for feedback.

Current epoll + send/recv seems to be enough for BTS + 1-2-3 Ms, but if we are 
to go with more Ms it might indeed be better to optimize more. In my experience 
most of the overhead was in python-related wrapping, but once that is removed 
it indeed the IO syscalls that will become the bottleneck. We do not forward a 
lot of data, as GSM bursts are small, but we do forward a lot of packets, as 
each GSM burst is being sent via 1 UDP message and to keep the forarding 
latency minimal we cannot coalesce those messages even for different slots in 
the same GSM frame. So using io_uring might indeed make sense at some point.

When/if we are to do that I would suggest to cosider using libosmocore directly 
instead of going through additional third-party library. It should hopefully 
easy to do that from Cython.

Kirill



--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/40055?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I83204545066a925dadbcd0b72cbbc2e3407129fe
Gerrit-Change-Number: 40055
Gerrit-PatchSet: 2
Gerrit-Owner: kirr <k...@nexedi.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <lafo...@osmocom.org>
Gerrit-CC: fixeria <vyanits...@sysmocom.de>
Gerrit-CC: osmith <osm...@sysmocom.de>
Gerrit-CC: pespin <pes...@sysmocom.de>
Gerrit-Attention: laforge <lafo...@osmocom.org>
Gerrit-Comment-Date: Sun, 20 Apr 2025 13:16:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <lafo...@osmocom.org>

Reply via email to