Attention is currently required from: neels. laforge has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/pysim/+/40096?usp=email )
Change subject: personalization: add param_source.py, implement batch personalization ...................................................................... Patch Set 3: (3 comments) File pySim/esim/saip/param_source.py: https://gerrit.osmocom.org/c/pysim/+/40096/comment/53b4167f_f48d274a?usp=email : PS3, Line 33: abstract if it's abstract, should it be an abc.ABC ? https://gerrit.osmocom.org/c/pysim/+/40096/comment/9aa7501a_9cbcced8?usp=email : PS3, Line 132: RandomDigitSource IMHO it's a bit unintuitive that the IncDigit inherits from RandomDigit. Maybe add a DigitSource from which both IncDigit + RandomDigit inherits? https://gerrit.osmocom.org/c/pysim/+/40096/comment/ddc198b0_c5058a11?usp=email : PS3, Line 133: 'incrementing sequence of digits' cosmetic: the docstring here uses single-quotes, below for the method it uses double-quotes. This looks a bit inconsistent. In the existing code base, I think we always use multi-line """ style comments for this, irrespective if the actual comment is just a single line. That makes it easier to expand it later on without having to change quoting style. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/40096?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I497c60c101ea0eea980e8b1a4b1f36c0eda39002 Gerrit-Change-Number: 40096 Gerrit-PatchSet: 3 Gerrit-Owner: neels <nhofm...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <lafo...@osmocom.org> Gerrit-Attention: neels <nhofm...@sysmocom.de> Gerrit-Comment-Date: Tue, 22 Apr 2025 08:48:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No
