Attention is currently required from: pespin.

iedemam has posted comments on this change by iedemam. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/40224?usp=email )

Change subject: meas_json: add command line option to specify binding ip
......................................................................


Patch Set 3:

(3 comments)

Patchset:

PS3:
Thanks @[email protected]. Updated accordingly.


File src/utils/meas_json.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/40224/comment/fef3b455_16211fbf?usp=email
 :
PS2, Line 47: static char *bind_ip = NULL;
> No need to "= NULL", global vars are zero-initialized by default.
Done


https://gerrit.osmocom.org/c/osmo-bsc/+/40224/comment/eee0b969_2c648a29?usp=email
 :
PS2, Line 257:  bind_ip = NULL;
> Not needed, global vars are zero-initialized by default.
Done



--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/40224?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I3baa80c95b373e3f9483a2778bd195ff99bbdec0
Gerrit-Change-Number: 40224
Gerrit-PatchSet: 3
Gerrit-Owner: iedemam <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <[email protected]>
Gerrit-Attention: pespin <[email protected]>
Gerrit-Comment-Date: Tue, 06 May 2025 12:13:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <[email protected]>

Reply via email to