Patch Set 1: (2 comments)
Patch Set 2 has also restored the ability for an fsm instance to have NULL passed as an id. I'm not sure if that was used before, but this way the behaviour is unchanged. https://gerrit.osmocom.org/#/c/6316/1/include/osmocom/core/fsm.h File include/osmocom/core/fsm.h: Line 90: char *id; > hm. We cannot change a "const char *" pointer? I always thought it states The issue here is the talloc_free() parameter being non-const. fsm.c:214:16: warning: passing argument 1 of ‘_talloc_free’ discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers] talloc_free(fi->id); I'll cast the argument to a void* in that call. https://gerrit.osmocom.org/#/c/6316/1/src/fsm.c File src/fsm.c: Line 205: bool osmo_fsm_inst_update_id(struct osmo_fsm_inst *fi, const char *id) > in general we return 0 on success and negative on error. Only predicate-ty Done -- To view, visit https://gerrit.osmocom.org/6316 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic216e5b11d4440f8e106a297714f4f06c1152945 Gerrit-PatchSet: 1 Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Owner: daniel <dwillm...@sysmocom.de> Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillm...@sysmocom.de> Gerrit-HasComments: Yes
