Review at https://gerrit.osmocom.org/6330
a_iface: Reduce log levels
During normal operation, regular messages occurring during processing
of a call / transaction should not be higher than LOGL_INFO.
Change-Id: Ibd04ade47b249406696c7d0b660474afc4f4adee
---
M src/libmsc/a_iface.c
M src/libmsc/a_iface_bssap.c
2 files changed, 18 insertions(+), 18 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/30/6330/1
diff --git a/src/libmsc/a_iface.c b/src/libmsc/a_iface.c
index f4706e5..1a4cebc 100644
--- a/src/libmsc/a_iface.c
+++ b/src/libmsc/a_iface.c
@@ -141,7 +141,7 @@
ss7 = osmo_ss7_instance_find(gsm_network->a.cs7_instance);
OSMO_ASSERT(ss7);
- LOGP(DMSC, LOGL_ERROR, "The calling BSC (%s) is unknown to this MSC
...\n",
+ LOGP(DMSC, LOGL_NOTICE, "The calling BSC (%s) is unknown to this MSC
...\n",
osmo_sccp_addr_name(ss7, addr));
return NULL;
}
@@ -433,7 +433,7 @@
{
struct msgb *msg;
- LOGPCONN(conn, LOGL_NOTICE, "Sending Clear command to BSC\n");
+ LOGPCONN(conn, LOGL_INFO, "Sending Clear command to BSC\n");
msg = gsm0808_create_clear_command(GSM0808_CAUSE_CALL_CONTROL);
return osmo_sccp_tx_data_msg(conn->a.scu, conn->a.conn_id, msg);
diff --git a/src/libmsc/a_iface_bssap.c b/src/libmsc/a_iface_bssap.c
index 1feecde..efae199 100644
--- a/src/libmsc/a_iface_bssap.c
+++ b/src/libmsc/a_iface_bssap.c
@@ -51,7 +51,7 @@
{
struct gsm_subscriber_connection *conn;
- LOGP(DMSC, LOGL_NOTICE, "Allocating A-Interface subscriber conn: lac
%i, conn_id %i\n", lac, conn_id);
+ LOGP(DMSC, LOGL_DEBUG, "Allocating A-Interface subscriber conn: lac %i,
conn_id %i\n", lac, conn_id);
conn = talloc_zero(network, struct gsm_subscriber_connection);
if (!conn)
@@ -69,7 +69,7 @@
memcpy(&conn->a.bsc_addr, &a_conn_info->bsc->bsc_addr,
sizeof(conn->a.bsc_addr));
llist_add_tail(&conn->entry, &network->subscr_conns);
- LOGP(DMSC, LOGL_NOTICE, "A-Interface subscriber connection successfully
allocated!\n");
+ LOGP(DMSC, LOGL_DEBUG, "A-Interface subscriber connection successfully
allocated!\n");
return conn;
}
@@ -164,7 +164,7 @@
return;
}
- LOGP(DMSC, LOGL_NOTICE, "Rx BSC UDT BSSMAP %s\n",
gsm0808_bssmap_name(msg->l3h[0]));
+ LOGP(DMSC, LOGL_DEBUG, "Rx BSC UDT BSSMAP %s\n",
gsm0808_bssmap_name(msg->l3h[0]));
switch (msg->l3h[0]) {
case BSS_MAP_MSG_RESET:
@@ -191,7 +191,7 @@
OSMO_ASSERT(a_conn_info);
OSMO_ASSERT(msg);
- LOGP(DMSC, LOGL_NOTICE, "Rx BSSMAP UDT: %s\n", msgb_hexdump_l2(msg));
+ LOGP(DMSC, LOGL_DEBUG, "Rx BSSMAP UDT: %s\n", msgb_hexdump_l2(msg));
if (msgb_l2len(msg) < sizeof(*bs)) {
LOGP(DMSC, LOGL_ERROR, "Error: Header is too short --
discarding message!\n");
@@ -232,7 +232,7 @@
uint8_t cause;
struct gsm_subscriber_connection *conn;
- LOGP(DMSC, LOGL_NOTICE, "BSC requested to clear connection
(conn_id=%i)\n", a_conn_info->conn_id);
+ LOGP(DMSC, LOGL_INFO, "BSC requested to clear connection
(conn_id=%i)\n", a_conn_info->conn_id);
tlv_parse(&tp, gsm0808_att_tlvdef(), msg->l3h + 1, msgb_l3len(msg) - 1,
0, 0);
if (!TLVP_PRESENT(&tp, GSM0808_IE_CAUSE)) {
@@ -264,7 +264,7 @@
{
int rc;
- LOGP(DMSC, LOGL_NOTICE, "Releasing connection (conn_id=%i)\n",
a_conn_info->conn_id);
+ LOGP(DMSC, LOGL_INFO, "Releasing connection (conn_id=%i)\n",
a_conn_info->conn_id);
rc = osmo_sccp_tx_disconn(scu, a_conn_info->conn_id,
NULL, SCCP_RELEASE_CAUSE_END_USER_ORIGINATED);
@@ -294,7 +294,7 @@
struct gsm_network *network = a_conn_info->network;
struct gsm_subscriber_connection *conn;
- LOGP(DMSC, LOGL_NOTICE, "BSC has completed layer 3 connection
(conn_id=%i)\n", a_conn_info->conn_id);
+ LOGP(DMSC, LOGL_INFO, "BSC has completed layer 3 connection
(conn_id=%i)\n", a_conn_info->conn_id);
tlv_parse(&tp, gsm0808_att_tlvdef(), msg->l3h + 1, msgb_l3len(msg) - 1,
0, 0);
if (!TLVP_PRESENT(&tp, GSM0808_IE_CELL_IDENTIFIER)) {
@@ -342,12 +342,12 @@
msgb_free(msg);
if (rc == MSC_CONN_ACCEPT) {
- LOGP(DMSC, LOGL_NOTICE, "User has been accepted by MSC.\n");
+ LOGP(DMSC, LOGL_INFO, "User has been accepted by MSC.\n");
return 0;
} else if (rc == MSC_CONN_REJECT)
- LOGP(DMSC, LOGL_NOTICE, "User has been rejected by MSC.\n");
+ LOGP(DMSC, LOGL_INFO, "User has been rejected by MSC.\n");
else
- LOGP(DMSC, LOGL_NOTICE, "User has been rejected by MSC (unknown
error)\n");
+ LOGP(DMSC, LOGL_INFO, "User has been rejected by MSC (unknown
error)\n");
return -EINVAL;
@@ -371,7 +371,7 @@
if (!conn)
goto fail;
- LOGP(DMSC, LOGL_NOTICE, "BSC sends clasmark update (conn_id=%i)\n",
conn->a.conn_id);
+ LOGP(DMSC, LOGL_DEBUG, "BSC sends clasmark update (conn_id=%i)\n",
conn->a.conn_id);
tlv_parse(&tp, gsm0808_att_tlvdef(), msg->l3h + 1, msgb_l3len(msg) - 1,
0, 0);
if (!TLVP_PRESENT(&tp, GSM0808_IE_CLASSMARK_INFORMATION_T2)) {
@@ -418,7 +418,7 @@
if (!conn)
goto fail;
- LOGP(DMSC, LOGL_NOTICE, "BSC sends cipher mode complete
(conn_id=%i)\n", conn->a.conn_id);
+ LOGP(DMSC, LOGL_DEBUG, "BSC sends cipher mode complete (conn_id=%i)\n",
conn->a.conn_id);
tlv_parse(&tp, gsm0808_att_tlvdef(), msg->l3h + 1, msgb_l3len(msg) - 1,
0, 0);
@@ -581,7 +581,7 @@
mgcp = conn->network->mgw.client;
OSMO_ASSERT(mgcp);
- LOGP(DMSC, LOGL_NOTICE, "BSC sends assignment complete message
(conn_id=%i)\n", conn->a.conn_id);
+ LOGP(DMSC, LOGL_INFO, "BSC sends assignment complete message
(conn_id=%i)\n", conn->a.conn_id);
tlv_parse(&tp, gsm0808_att_tlvdef(), msg->l3h + 1, msgb_l3len(msg) - 1,
0, 0);
@@ -628,7 +628,7 @@
return -1;
}
- LOGP(DMSC, LOGL_NOTICE, "Rx MSC DT1 BSSMAP %s\n",
gsm0808_bssmap_name(msg->l3h[0]));
+ LOGP(DMSC, LOGL_DEBUG, "Rx MSC DT1 BSSMAP %s\n",
gsm0808_bssmap_name(msg->l3h[0]));
switch (msg->l3h[0]) {
case BSS_MAP_MSG_CLEAR_RQST:
@@ -679,7 +679,7 @@
return -EINVAL;
}
- LOGP(DMSC, LOGL_NOTICE, "BSC sends layer 3 dtap (conn_id=%i)\n",
conn->a.conn_id);
+ LOGP(DMSC, LOGL_DEBUG, "BSC sends layer 3 dtap (conn_id=%i)\n",
conn->a.conn_id);
/* msc_dtap expects the dtap payload in l3h */
msg->l3h = msg->l2h + 3;
@@ -698,7 +698,7 @@
OSMO_ASSERT(a_conn_info);
OSMO_ASSERT(msg);
- LOGP(DMSC, LOGL_NOTICE, "Rx BSC DT: %s\n", msgb_hexdump(msg));
+ LOGP(DMSC, LOGL_DEBUG, "Rx BSC DT: %s\n", msgb_hexdump(msg));
if (msgb_l2len(msg) < sizeof(struct bssmap_header)) {
LOGP(DMSC, LOGL_NOTICE, "The header is too short -- discarding
message!\n");
--
To view, visit https://gerrit.osmocom.org/6330
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibd04ade47b249406696c7d0b660474afc4f4adee
Gerrit-PatchSet: 1
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Owner: Harald Welte <lafo...@gnumonks.org>
