Attention is currently required from: lynxis lazus. fixeria has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/37903?usp=email )
Change subject: s2b: add PDN type to the create session request ...................................................................... Patch Set 1: (3 comments) File src/epdg_gtpc_s2b.erl: https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/37903/comment/4e76acab_26bcfa44?usp=email : PS1, Line 87: atom(). It's probably a good idea to define possible atom values here? ``` -type pdn_type() :: ipv4 | ipv6 | ipv4v6. ``` This allows dializer to catch typos in atoms. https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/37903/comment/c8dd76a5_7f9e8228?usp=email : PS1, Line 537: <<0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0>> Not critical, but you could do this as follows: ``` << 16#00:(8 * 4) >> %% for ipv4 << 16#00:(8 * 16) >> %% for ipv6 << 16#00:(8 * 20) >> %% for ipv4v6 ``` File src/epdg_ue_fsm.erl: https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/37903/comment/53e35966_d970750b?usp=email : PS1, Line 70: atom(), You can export `-type pdn_type` from `epdg_gtpc_s2b.erl` and use it here. -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/37903?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: I52c9b2db38489404dbe2aac907089a0a6414c9b0 Gerrit-Change-Number: 37903 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lyn...@fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanits...@sysmocom.de> Gerrit-Attention: lynxis lazus <lyn...@fe80.eu> Gerrit-Comment-Date: Fri, 23 May 2025 06:24:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No
