Attention is currently required from: fixeria, pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40367?usp=email )
Change subject: 5gc: initial ...................................................................... Patch Set 2: Code-Review+1 (3 comments) File 5gc/open5gs/open5gs-amf.yaml: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40367/comment/f111d693_a77eabe9?usp=email : PS2, Line 58: ################################################################################ maybe worth removing all these comments and linking to the original config for reference instead, similar to https://gerrit.osmocom.org/c/docker-playground/+/35103? this makes it easier to read the file, and makes future diffs related to upstream config changes smaller (otherwise diffs need to include all the commented out stuff too, or they never get updated and become stale) File 5gc/regen_makefile.sh: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40367/comment/1ca90aab_8e97cfaa?usp=email : PS2, Line 6: # *.c remove these commented out lines? File Makefile: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40367/comment/81a6c35b_5060b404?usp=email : PS1, Line 63: PARALLEL_MAKE ?= -j4 > unrelated change Done -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40367?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I867433c87c6da2f0d1f299245aedf4830acbf539 Gerrit-Change-Number: 40367 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pes...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osm...@sysmocom.de> Gerrit-CC: fixeria <vyanits...@sysmocom.de> Gerrit-Attention: fixeria <vyanits...@sysmocom.de> Gerrit-Attention: pespin <pes...@sysmocom.de> Gerrit-Comment-Date: Mon, 26 May 2025 09:56:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: fixeria <vyanits...@sysmocom.de>
