Attention is currently required from: daniel, laforge, pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/40327?usp=email )
Change subject: asp: Avoid double-free of received msg if conn is teared down ...................................................................... Patch Set 3: (2 comments) Patchset: PS2: > So what's the root problem according to you? […] The root problem is that `iofd` code is transferring the talloc ownership to API users that may not expect/want this. As I suggested in the ticket, in my view talloc ownership should be explicitly **taken** by the user of `iofd` (be it netif stuff or whatever else), and not given away by the `iofd` itself. I am not against fine-grained talloc ownership, and you can still achieve that by doing `talloc_steal()` like you're doing in this patch and did in `lapdm` code in libosmocore. Let's just allocate the `msgb` as a child of the `tall_msgb_ctx` by default and leave it up to the user of `iofd`: whether `talloc_steal()` explicitly (if needed) or keep it there for performance reasons. Patchset: PS3: > ping. This is a fix for a severe bug and has been here for 1 week and a half > and almost no feedback. Please add `Related: OS#6728` and feel free to merge: I am not blocking. But I still see this as a band-aid solution treating the symptoms, but not the "disease". There definitely are other places where we (and even worse, our customers) will be bitten by this again and again. Feels like we're fighting the hydra. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/40327?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I69f80f611c14db2b328dafd4a90247c6f2dac6fd Gerrit-Change-Number: 40327 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pes...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillm...@sysmocom.de> Gerrit-Reviewer: fixeria <vyanits...@sysmocom.de> Gerrit-Reviewer: laforge <lafo...@osmocom.org> Gerrit-Reviewer: osmith <osm...@sysmocom.de> Gerrit-Attention: laforge <lafo...@osmocom.org> Gerrit-Attention: pespin <pes...@sysmocom.de> Gerrit-Attention: daniel <dwillm...@sysmocom.de> Gerrit-Comment-Date: Tue, 27 May 2025 10:45:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pes...@sysmocom.de> Comment-In-Reply-To: fixeria <vyanits...@sysmocom.de>
