Attention is currently required from: lynxis lazus. Jenkins Builder has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/40436?usp=email )
Change subject: gsn: fix coding style issue ...................................................................... Patch Set 2: (9 comments) File include/osmocom/gtp/gsn.h: Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ggsn/+/40436/comment/2d318433_6fb4b990?usp=email : PS2, Line 141: int (*cb_data_ind)(struct pdp_t * pdp, "foo * bar" should be "foo *bar" Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ggsn/+/40436/comment/0bf05477_3c4e3542?usp=email : PS2, Line 150: int (*cb)(struct sockaddr_in * peer)); "foo * bar" should be "foo *bar" Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ggsn/+/40436/comment/ca055a36_7fa20f3c?usp=email : PS2, Line 153: int (*cb)(struct sockaddr_in * peer)); "foo * bar" should be "foo *bar" Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ggsn/+/40436/comment/32214389_a44d2031?usp=email : PS2, Line 156: int (*cb)(struct sockaddr_in * peer, union gtpie_member **ie)); "foo * bar" should be "foo *bar" Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ggsn/+/40436/comment/ceca4897_6ffff70f?usp=email : PS2, Line 159: int (*cb)(int type, int cause, struct pdp_t * pdp, "foo * bar" should be "foo *bar" Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ggsn/+/40436/comment/3558e4b9_5e0ab9bb?usp=email : PS2, Line 163: int (*cb)(struct sockaddr_in * peer, "foo * bar" should be "foo *bar" Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ggsn/+/40436/comment/3f2f1024_d139b66e?usp=email : PS2, Line 167: int (*cb)(struct sockaddr_in * peer, "foo * bar" should be "foo *bar" Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ggsn/+/40436/comment/fad34a4b_dbf38e6a?usp=email : PS2, Line 172: int (*cb)(struct gsn_t * gsn, struct sockaddr_in * peer, "foo * bar" should be "foo *bar" Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ggsn/+/40436/comment/26f8b3da_07b8280d?usp=email : PS2, Line 172: int (*cb)(struct gsn_t * gsn, struct sockaddr_in * peer, "foo * bar" should be "foo *bar" -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/40436?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: I1d978ed32619b626e82aa70887ac94b82c4de378 Gerrit-Change-Number: 40436 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lyn...@fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: lynxis lazus <lyn...@fe80.eu> Gerrit-Comment-Date: Wed, 04 Jun 2025 16:56:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No
