Attention is currently required from: fixeria, pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40472?usp=email )
Change subject: stp: IPA: Introduce test TC_beat ...................................................................... Patch Set 3: Code-Review+1 (1 comment) File stp/STP_Tests_IPA.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40472/comment/403a5291_c3598e78?usp=email : PS3, Line 495: var IpaCcmMsgtype ipa_ping_msg := IPAC_MSGT_PING; : v > Not critical, but this is another place where additional variables could be > avoided by passing `IPAC […] I'd agree. But my mind seems to rememer that somehow enum2int only works on typed variables and not immediate constants? -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40472?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I3d762fb4780aaa9931c3841cce69da6ee95529f3 Gerrit-Change-Number: 40472 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pes...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanits...@sysmocom.de> Gerrit-Reviewer: laforge <lafo...@osmocom.org> Gerrit-Attention: fixeria <vyanits...@sysmocom.de> Gerrit-Attention: pespin <pes...@sysmocom.de> Gerrit-Comment-Date: Mon, 16 Jun 2025 21:18:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: fixeria <vyanits...@sysmocom.de>
