Attention is currently required from: Hoernchen, osmith.

pespin has posted comments on this change by Hoernchen. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27345?usp=email )

Change subject: octsim: tester support
......................................................................


Patch Set 5:

(3 comments)

File octsim/OCTSIM_Tests.cfg:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27345/comment/9693171a_9b262482?usp=email
 :
PS5, Line 10: LogFile := "%e-%c-%h-%r.%s"
I don't recall we have all of this in any testsuite. Are you sure this is 
needed? is it for personal specific debugging?


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27345/comment/2298dbc1_93199358?usp=email
 :
PS5, Line 28: #OCTSIM_Tests.TC_test_grouped
this can be removed.


File octsim/OCTSIM_Tests.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27345/comment/38513726_5e58fbaa?usp=email
 :
PS5, Line 583: python to generate tests
This can most probably go into a separate file?



--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27345?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Id7c7e529a5444cffc8e79b385959a522dc9a6beb
Gerrit-Change-Number: 27345
Gerrit-PatchSet: 5
Gerrit-Owner: Hoernchen <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <[email protected]>
Gerrit-CC: pespin <[email protected]>
Gerrit-Attention: osmith <[email protected]>
Gerrit-Attention: Hoernchen <[email protected]>
Gerrit-Comment-Date: Wed, 25 Jun 2025 11:28:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No

Reply via email to