Attention is currently required from: laforge, pespin.

osmith has posted comments on this change by pespin. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40530?usp=email )

Change subject: stp: ipa: Introduce test TC_combinedlset_loadshare
......................................................................


Patch Set 1: Code-Review+1

(1 comment)

File stp/STP_Tests_IPA.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40530/comment/33c6576b_a4cfbcac?usp=email
 :
PS1, Line 539: unknwon_dynamic_asp
```suggestion
private function f_tc_combinedlset_loadshare(boolean unknown_dynamic_asp)
```

this typo is also elsewhere in this file, maybe create a separate patch to fix 
that?



--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40530?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I029ac9f3c664d2f30cddc36f6eb1b39295689247
Gerrit-Change-Number: 40530
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Reviewer: osmith <[email protected]>
Gerrit-Attention: laforge <[email protected]>
Gerrit-Attention: pespin <[email protected]>
Gerrit-Comment-Date: Thu, 26 Jun 2025 10:37:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes

Reply via email to