Attention is currently required from: jolly, pespin. laforge has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/libosmocore/+/40489?usp=email )
Change subject: Allow io_uring_submit batching just ahead of poll/select ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > Several comments: […] I think for now it's good to have it optional so we can compare, indeed. The delayed submit will likely increase throughput - but at the cost of some added latency. I think it's worth it, but before we've done extensive benchmarks (and asked users to try it in loaded production setups) it might be good to have it disabled by default. As we don't have VTY in all libosmocore applications, and IO_URING is enabled via environment, adding another env variable is fine with me. But I agree with @pespin regarding the global variable. Note that it will likely have to be __thread / thread-local-storage like all of our I/O. It should be very chaep to set and check compared to unneeded io_uring_submit() all the time without knowig if we actually did submit any new sqe during that given select loop iteration. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/40489?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Id34fe2ced32c63d15b14810e145744f7509064cc Gerrit-Change-Number: 40489 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andr...@eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <lafo...@osmocom.org> Gerrit-CC: pespin <pes...@sysmocom.de> Gerrit-Attention: jolly <andr...@eversberg.eu> Gerrit-Attention: pespin <pes...@sysmocom.de> Gerrit-Comment-Date: Fri, 04 Jul 2025 14:12:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pes...@sysmocom.de>
