Attention is currently required from: pespin. lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/40432?usp=email )
Change subject: gtpie: make ies const for getter ...................................................................... Patch Set 2: (1 comment) File include/osmocom/gtp/gtpie.h: https://gerrit.osmocom.org/c/osmo-ggsn/+/40432/comment/6524e19c_c7ac77d6?usp=email : PS1, Line 304: extern int gtpie_getie(union gtpie_member * const ie[], int type, int instance); > Ah nevermind, it's an out param right? No, it returns the output for getie(). But I tried to change it to "const union gtpie_member * const ie[]" which doesn't work. I'm not sure, problably, because it expects the objects within ie[] to be const which is a different type. Any other recommendation? here is the output of gcc ``` gtp.c:2160:34: error: passing argument 1 of 'gtpie_gettv4' from incompatible pointer type [-Wincompatible-pointer-types] 2160 | if (gtpie_gettv4(ie, GTPIE_CHARGING_ID, 0, &pdp->cid)) { | ^~ | | | union gtpie_member ** ../include/osmocom/gtp/gtpie.h:314:58: note: expected 'const union gtpie_member * const*' but argument is of type 'union gtpie_member **' 314 | extern int gtpie_gettv4(union gtpie_member const * const ie[], int type, int instance, | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~ ``` -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/40432?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: I43195314b1cf416a1f2fd4d3ddd48c4eee462b0b Gerrit-Change-Number: 40432 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lyn...@fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <lafo...@osmocom.org> Gerrit-Reviewer: pespin <pes...@sysmocom.de> Gerrit-Attention: pespin <pes...@sysmocom.de> Gerrit-Comment-Date: Fri, 04 Jul 2025 20:39:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pes...@sysmocom.de> Comment-In-Reply-To: lynxis lazus <lyn...@fe80.eu>
