laforge has submitted this change. (
https://gerrit.osmocom.org/c/libosmo-sigtran/+/40621?usp=email )
Change subject: xua_snm: Tx DUNA/DAVA to ASPs with single AS and no coordinated
rctx
......................................................................
xua_snm: Tx DUNA/DAVA to ASPs with single AS and no coordinated rctx
ss7_asp_get_all_rctx_be() properly skips rctx=0 as per special osmocom
meaning "no rctx IE". However, in this case the count of rctx was used
to skip sending notifications to ASPs not associated to the AS/PC becoming
available/unavailable.
This fixes problems when both osmo-bsc and osmo-stp configure the
routing-key with rctx=0, meaning both agree to use no rctx.
Change-Id: Ibda223090e7d503d8501c50f4cdf0b8b8c65a724
---
M src/xua_snm.c
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
osmith: Looks good to me, but someone else must approve
laforge: Looks good to me, approved
Jenkins Builder: Verified
diff --git a/src/xua_snm.c b/src/xua_snm.c
index 04568d2..e613573 100644
--- a/src/xua_snm.c
+++ b/src/xua_snm.c
@@ -232,7 +232,7 @@
num_rctx = ss7_asp_get_all_rctx_be(asp, rctx, ARRAY_SIZE(rctx),
as);
/* this can happen if the given ASP is only in the AS that
reports the change,
* which shall be excluded */
- if (num_rctx == 0)
+ if (num_rctx == 0 && osmo_ss7_as_has_asp(as, asp))
continue;
xua_tx_snm_available(asp, rctx, num_rctx, aff_pc, num_aff_pc,
info_str, available);
}
--
To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/40621?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: Ibda223090e7d503d8501c50f4cdf0b8b8c65a724
Gerrit-Change-Number: 40621
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <[email protected]>
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Reviewer: osmith <[email protected]>
