Attention is currently required from: pespin.

laforge has posted comments on this change by pespin. ( 
https://gerrit.osmocom.org/c/osmo-msc/+/40630?usp=email )

Change subject: msc: Initial implementation of N-PCSTATE.ind
......................................................................


Patch Set 1:

(3 comments)

File src/libmsc/sccp_ran.c:

https://gerrit.osmocom.org/c/osmo-msc/+/40630/comment/697a42d7_aae5c31d?usp=email
 :
PS1, Line 84:   LOGP(DMSC, LOGL_DEBUG, "N-PCSTATE ind: affected_pc=%u 
sp_status=%s remote_sccp_status=%s\n",
as usual, please print pointcodes in the user-configured point-code format, not 
[just?] as integer.


https://gerrit.osmocom.org/c/osmo-msc/+/40630/comment/792e5b53_8b8bbb33?usp=email
 :
PS1, Line 148:                       "now unreachable: N-PCSTATE ind: pc=%u 
sp_status=%s remote_sccp_status=%s\n",
as usual, please print pointcodes in the user-configured point-code format, not 
[just?] as integer.


https://gerrit.osmocom.org/c/osmo-msc/+/40630/comment/57cf2b6f_c7f19529?usp=email
 :
PS1, Line 156:                       "now available: N-PCSTATE ind: pc=%u 
sp_status=%s remote_sccp_status=%s\n",
as usual, please print pointcodes in the user-configured point-code format, not 
[just?] as integer.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/40630?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: Ice1b2c163b1b0d134fcaa1c8bf543038a35fabdf
Gerrit-Change-Number: 40630
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <[email protected]>
Gerrit-Attention: pespin <[email protected]>
Gerrit-Comment-Date: Thu, 10 Jul 2025 19:05:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No

Reply via email to