pespin has submitted this change. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40639?usp=email )
Change subject: GSUP Fix missing IMSI template present restriction in
tr_GSUP_SAI_REQ
......................................................................
GSUP Fix missing IMSI template present restriction in tr_GSUP_SAI_REQ
I got this DTE while running SGSN_Tests_Iu.TC_attach_pdp_act_user:
"""
GSUP_Templates.ttcn:381 Dynamic test case error: Restriction `present' on
template of type hexstring violated.
"""
According to GSUP documentation, the IMSI param is mandatory.
Upon fixing it, the compiler found the user causing the problem:
"""
BSSGP_ConnHdlr.ttcn:797.49: error: Restriction on template formal parameter
does not allow usage of any or omit
"""
That error is also fixed in this same commit.
Change-Id: Iea712df2f922fe5eb16e116f7a4609a0e20233b4
---
M library/GSUP_Templates.ttcn
M sgsn/BSSGP_ConnHdlr.ttcn
2 files changed, 2 insertions(+), 2 deletions(-)
Approvals:
Jenkins Builder: Verified
osmith: Looks good to me, but someone else must approve
lynxis lazus: Looks good to me, approved
diff --git a/library/GSUP_Templates.ttcn b/library/GSUP_Templates.ttcn
index 327f7f6..227a7d2 100644
--- a/library/GSUP_Templates.ttcn
+++ b/library/GSUP_Templates.ttcn
@@ -378,7 +378,7 @@
valueof(ts_GSUP_IE_RAND(rand))
});
-template GSUP_PDU tr_GSUP_SAI_REQ(template hexstring imsi) :=
+template GSUP_PDU tr_GSUP_SAI_REQ(template (present) hexstring imsi) :=
tr_GSUP_IMSI(OSMO_GSUP_MSGT_SEND_AUTH_INFO_REQUEST, imsi);
template GSUP_PDU tr_GSUP_SAI_REQ_UMTS_AKA_RESYNC(
diff --git a/sgsn/BSSGP_ConnHdlr.ttcn b/sgsn/BSSGP_ConnHdlr.ttcn
index 1b2e5a0..2b95ec0 100644
--- a/sgsn/BSSGP_ConnHdlr.ttcn
+++ b/sgsn/BSSGP_ConnHdlr.ttcn
@@ -794,7 +794,7 @@
Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail,
"Service Request: Unexpected GMM Auth Req");
}
- [not expect_auth] GSUP.receive(tr_GSUP_SAI_REQ(*)) {
+ [not expect_auth] GSUP.receive(tr_GSUP_SAI_REQ(?)) {
Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail,
"Service Request: Unexpected GSUP SAI Req");
}
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40639?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Iea712df2f922fe5eb16e116f7a4609a0e20233b4
Gerrit-Change-Number: 40639
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pes...@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: lynxis lazus <lyn...@fe80.eu>
Gerrit-Reviewer: osmith <osm...@sysmocom.de>
Gerrit-Reviewer: pespin <pes...@sysmocom.de>
