lynxis lazus has submitted this change. (
https://gerrit.osmocom.org/c/osmo-sgsn/+/40653?usp=email )
Change subject: gprs_gmm: fix endianess of GSM48_IE_GMM_PDP_CTX_STATUS
......................................................................
gprs_gmm: fix endianess of GSM48_IE_GMM_PDP_CTX_STATUS
The pdp_status is actually encoded as little endian,
but there is no tlvp_val16le yet.
Change-Id: Ib9bee2f8d0b1f89986d15cf3ce6404ad76378c8c
---
M src/sgsn/gprs_gmm.c
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
Jenkins Builder: Verified
pespin: Looks good to me, approved
fixeria: Looks good to me, but someone else must approve
daniel: Looks good to me, but someone else must approve
diff --git a/src/sgsn/gprs_gmm.c b/src/sgsn/gprs_gmm.c
index c34c1a1..1fa73b9 100644
--- a/src/sgsn/gprs_gmm.c
+++ b/src/sgsn/gprs_gmm.c
@@ -1975,7 +1975,8 @@
/* Look at PDP Context Status IE and see if MS's view of
* activated/deactivated NSAPIs agrees with our view */
if (TLVP_PRESENT(&tp, GSM48_IE_GMM_PDP_CTX_STATUS)) {
- uint16_t pdp_status = tlvp_val16be(&tp,
GSM48_IE_GMM_PDP_CTX_STATUS);
+ /* TODO: Use tlvp_val16le when available */
+ uint16_t pdp_status = osmo_load16le(TLVP_VAL(&tp,
GSM48_IE_GMM_PDP_CTX_STATUS));
process_ms_ctx_status(ctx, pdp_status);
--
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/40653?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: Ib9bee2f8d0b1f89986d15cf3ce6404ad76378c8c
Gerrit-Change-Number: 40653
Gerrit-PatchSet: 3
Gerrit-Owner: lynxis lazus <lyn...@fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillm...@sysmocom.de>
Gerrit-Reviewer: fixeria <vyanits...@sysmocom.de>
Gerrit-Reviewer: lynxis lazus <lyn...@fe80.eu>
Gerrit-Reviewer: pespin <pes...@sysmocom.de>
