Attention is currently required from: lynxis lazus. fixeria has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40666?usp=email )
Change subject: GSUP Templates: fix empty destination_name in GSUP ISD/UL ...................................................................... Patch Set 2: Code-Review-1 (4 comments) File library/GSUP_Templates.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40666/comment/d1f6a494_e4401763?usp=email : PS2, Line 421: omit This change makes no sense to me, since `ts_GSUP_UL_RES` cannot yield `omit`. It's always a value. https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40666/comment/54e7c42c_6aba1866?usp=email : PS2, Line 437: omit This change makes no sense to me, since `ts_GSUP_UL_RES` cannot yield `omit`. It's always a value. https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40666/comment/3a50ba04_79283e21?usp=email : PS2, Line 447: omit likewise, it should be `(value)` https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40666/comment/4a5928f6_c6adb274?usp=email : PS2, Line 448: template (omit) octetstring source_name := omit, : please fix alignment here -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40666?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia89b5a82665e407fa578e5209fbcde0676326df0 Gerrit-Change-Number: 40666 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lyn...@fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanits...@sysmocom.de> Gerrit-Reviewer: pespin <pes...@sysmocom.de> Gerrit-Attention: lynxis lazus <lyn...@fe80.eu> Gerrit-Comment-Date: Tue, 15 Jul 2025 19:25:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes
