Jenkins Builder has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/40721?usp=email )
Change subject: 7816 fsm: drop inverse convention lut for arm ...................................................................... Patch Set 1: (4 comments) File ccid_common/iso7816_fsm.c: Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/40721/comment/c99fefe9_27b2a565?usp=email : PS1, Line 153: #define invert_flip_uint8(XX) \ do {} while (0) macros should not be semicolon terminated Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/40721/comment/f589fec6_3dca8e27?usp=email : PS1, Line 159: __asm__ volatile("rbit %0, %0 \n\t" \ unnecessary whitespace before a quoted newline Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/40721/comment/168a5400_ba93fac8?usp=email : PS1, Line 160: "uxtb.w %0, %0, ror #24 \n\t" \ unnecessary whitespace before a quoted newline Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/40721/comment/234b7939_b4c5807d?usp=email : PS1, Line 184: #define invert_flip_uint8(XX) \ do {} while (0) macros should not be semicolon terminated -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/40721?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: I1c6f1c4b733074201cb02c0b9e7cf80a9f8dca7c Gerrit-Change-Number: 40721 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen <[email protected]> Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Fri, 18 Jul 2025 16:10:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No
