Attention is currently required from: jolly. pespin has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/libosmocore/+/40493?usp=email )
Change subject: Add multiple messages buffers to io_uring write operations ...................................................................... Patch Set 6: (3 comments) File src/core/osmo_io.c: https://gerrit.osmocom.org/c/libosmocore/+/40493/comment/1b6fd4ed_62c4364d?usp=email : PS4, Line 248: lh = iofd->tx_queue.msg_queue.prev; > I added the suggested llist_last_entry_or_null(). You added it to libosmocore but apparently not using it here? https://gerrit.osmocom.org/c/libosmocore/+/40493/comment/ed8b74ac_3c8644c8?usp=email : PS4, Line 517: msghdr = iofd_txqueue_tail(iofd); > Done Not done, not answered, no comment explaining in code. https://gerrit.osmocom.org/c/libosmocore/+/40493/comment/e3905381_70389350?usp=email : PS4, Line 539: rc = iofd_txqueue_enqueue(iofd, msghdr); > If io_uring processes a msghdr, it has been removed from the queue before, so > everything within the […] Done -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/40493?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I8c4e0a785cf66becd7fb5b2caf718c9724b56686 Gerrit-Change-Number: 40493 Gerrit-PatchSet: 6 Gerrit-Owner: jolly <andr...@eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pes...@sysmocom.de> Gerrit-Attention: jolly <andr...@eversberg.eu> Gerrit-Comment-Date: Tue, 22 Jul 2025 15:40:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: jolly <andr...@eversberg.eu> Comment-In-Reply-To: pespin <pes...@sysmocom.de>
