Attention is currently required from: fixeria, pespin. osmith has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-dev/+/40770?usp=email )
Change subject: gen_makefile: support new Osmocom erlang makefiles ...................................................................... Patch Set 1: (1 comment) File gen_makefile.py: https://gerrit.osmocom.org/c/osmo-dev/+/40770/comment/f8d6a600_ff73bae3?usp=email : PS1, Line 375: for i in {build_proj}/default/bin/*; do \\ : if [ -e "$$i" ]; then \\ : install -v -Dm755 "$$i" -t {shlex.quote(args.install_prefix)}/bin/; \\ > setup_gen Oh interesting! Apparently this doesn't get created in default/bin when REBAR_BASE_DIR is set (as we do when using osmo-dev). But yeah it's not great to rely on that, let's find a better way. > `if grep -q "^install:" Makefile; then` I would also have preferred this, but the problem is that the Makefile before https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/40756 already has an install target, so this does not work. However, how about we add an `install-osmo-dev: install` target to the Makefile to make it explicit what osmo-dev should do, and then check for that here? (`if grep -q "^install-osmo-dev:" Makefile; then`) -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/40770?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: I92d6fc6eb5a11068d4b3baca55dfb3abdedbbbf1 Gerrit-Change-Number: 40770 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osm...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanits...@sysmocom.de> Gerrit-Reviewer: pespin <pes...@sysmocom.de> Gerrit-Attention: fixeria <vyanits...@sysmocom.de> Gerrit-Attention: pespin <pes...@sysmocom.de> Gerrit-Comment-Date: Tue, 29 Jul 2025 15:00:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanits...@sysmocom.de>
