Attention is currently required from: laforge, lynxis lazus.

fixeria has posted comments on this change by lynxis lazus. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39256?usp=email )

Change subject: SGSN: add TC_attach_gmm_attach_req_while_gmm_attach_changed
......................................................................


Patch Set 10:

(3 comments)

File sgsn/SGSN_Tests.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39256/comment/a77e3823_e0b65a37?usp=email
 :
PS10, Line 2085: FIXME: Extract P-TMSI, if any. Only send Complete if necessary
Isn't this still relevant here?


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39256/comment/852de5ad_a4476233?usp=email
 :
PS10, Line 2203: mi := valueof(ts_MI_IMSI_LV(g_pars.imsi));
unused assignment


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39256/comment/b7708b75_e7f756b6?usp=email
 :
PS10, Line 2220: as_gmm_auth
Unlike the previous testcases, here the authentication seems to be optional?

Again, the sequence of events is really vague. This testcase will pass if the 
SGSN sends `GMM ATTACH ACCEPT` straight away, bypassing identification and 
authentication.



--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39256?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ia721d3c29bf09014b197670ae02d1cd1901750bc
Gerrit-Change-Number: 39256
Gerrit-PatchSet: 10
Gerrit-Owner: lynxis lazus <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Reviewer: pespin <[email protected]>
Gerrit-CC: fixeria <[email protected]>
Gerrit-Attention: laforge <[email protected]>
Gerrit-Attention: lynxis lazus <[email protected]>
Gerrit-Comment-Date: Mon, 25 Aug 2025 18:37:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No

Reply via email to