Attention is currently required from: keith.

pespin has posted comments on this change by keith. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/40917?usp=email )

Change subject: Add functions to set LAC/CI on a BTS and update hashtables.
......................................................................


Patch Set 6:

(5 comments)

Patchset:

PS6:
@ke...@rhizomatica.org as requested I'll rework the patch myself with the small 
changes mentioned below and submit, thanks!


File include/osmocom/bsc/bts.h:

https://gerrit.osmocom.org/c/osmo-bsc/+/40917/comment/f3b67ad7_0535eec0?usp=email
 :
PS6, Line 828: int gsm_bts_set_lac(struct gsm_bts *bts, int lac);
uint16_t lac


https://gerrit.osmocom.org/c/osmo-bsc/+/40917/comment/ed67ea10_6bef3916?usp=email
 :
PS6, Line 829: int gsm_bts_set_ci(struct gsm_bts *bts, int ci);
uint16_t cell_identity


File src/osmo-bsc/bts_ctrl.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/40917/comment/e1f08de6_2163182d?usp=email
 :
PS6, Line 250:  cmd->reply = talloc_asprintf(cmd, "%d", 
bts->location_area_code);
PRIu16


https://gerrit.osmocom.org/c/osmo-bsc/+/40917/comment/818d1e21_f480047b?usp=email
 :
PS6, Line 286:  cmd->reply = talloc_asprintf(cmd, "%d", bts->cell_identity);
PRIu16



--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/40917?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: If9509534bd4a75f8ed8fb3e0a6bec701c7596861
Gerrit-Change-Number: 40917
Gerrit-PatchSet: 6
Gerrit-Owner: keith <ke...@rhizomatica.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanits...@sysmocom.de>
Gerrit-Reviewer: keith <ke...@rhizomatica.org>
Gerrit-Reviewer: pespin <pes...@sysmocom.de>
Gerrit-CC: laforge <lafo...@osmocom.org>
Gerrit-Attention: keith <ke...@rhizomatica.org>
Gerrit-Comment-Date: Tue, 26 Aug 2025 08:42:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No

Reply via email to