Attention is currently required from: osmith. dexter has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/40936?usp=email )
Change subject: contrib: add a tool to parse the SIMA response from an eUICC ...................................................................... Patch Set 2: (4 comments) File contrib/sima-response-tool.py: https://gerrit.osmocom.org/c/pysim/+/40936/comment/3dff30b4_35c571d5?usp=email : PS1, Line 57: 8 : 'template-not-supported', : 9 : 'feature-not-supported', > ```suggestion […] Thanks. (I have tried to get those constants from asn1tools using introspection, but I couldn't figure this out. Unlike the ServicesList (see saip-tool.py), this is just a plain integer type.) https://gerrit.osmocom.org/c/pysim/+/40936/comment/7e0745d2_0a71f0ee?usp=email : PS1, Line 74: propritary > ```suggestion […] Done https://gerrit.osmocom.org/c/pysim/+/40936/comment/5f0461b4_d757dbfb?usp=email : PS1, Line 77: return "%d (unknown, propritary?)" % (status, status) > contrib/sima-response-tool. […] Done https://gerrit.osmocom.org/c/pysim/+/40936/comment/0361bb31_74aee998?usp=email : PS1, Line 93: if euicc_response_decoded.get('profileInstallationAborted', False) is None: > Is comparing against `is None` correct here? I wonder if it should be > compared against `is True` as […] I agree, this is confusing. The type is defined as profileInstallationAborted NULL OPTIONAL. This means, that when it is present it has the value None, so None effectively means True then. False is when profileInstallationAborted is not present at all. Unfortunately the confusion already starts with the ASN.1 definition. I have added a comment to make it more clear. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/40936?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ida4c3c5446653b283a3869c0c387f328ae51e55e Gerrit-Change-Number: 40936 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pma...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: osmith <osm...@sysmocom.de> Gerrit-Attention: osmith <osm...@sysmocom.de> Gerrit-Comment-Date: Wed, 27 Aug 2025 08:31:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osm...@sysmocom.de>
