Attention is currently required from: fixeria, pespin. lynxis lazus has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/40961?usp=email )
Change subject: Split Iu RANAP RAB PS act/deact over different layers ...................................................................... Patch Set 4: (1 comment) File src/sgsn/gprs_gmm.c: https://gerrit.osmocom.org/c/osmo-sgsn/+/40961/comment/48f1dbbd_50e45702?usp=email : PS4, Line 1016: if (ctx->ran_type == MM_CTX_T_UTRAN_Iu && Please don't check here for UTRAN_Iu. The check for Iu would be much better if you do it on line 1012, because Service Request is only valid for Iu and I think it is already checked earlier. *BUT* The real reason why I don't want to have here, because gmm_auth() will be removed anyways by the vlr patch series and I want to keep the changes of your commit minimal. -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/40961?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I98788468b7e50619cfd99b3aef2311bb601fb6be Gerrit-Change-Number: 40961 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pes...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanits...@sysmocom.de> Gerrit-CC: lynxis lazus <lyn...@fe80.eu> Gerrit-Attention: fixeria <vyanits...@sysmocom.de> Gerrit-Attention: pespin <pes...@sysmocom.de> Gerrit-Comment-Date: Thu, 28 Aug 2025 09:56:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No
