Attention is currently required from: pespin.

lynxis lazus has posted comments on this change by pespin. ( 
https://gerrit.osmocom.org/c/osmo-sgsn/+/40975?usp=email )

Change subject: ranap: Improve error handling in Rx RESET
......................................................................


Patch Set 1:

(2 comments)

File src/sgsn/gprs_ranap.c:

https://gerrit.osmocom.org/c/osmo-sgsn/+/40975/comment/1d6b992e_93dfd770?usp=email
 :
PS1, Line 332: /* Send CL RANAP message over SCCP: */
> Connectionless. […]
Done


https://gerrit.osmocom.org/c/osmo-sgsn/+/40975/comment/31b39420_a7bca811?usp=email
 :
PS1, Line 679:  if (ies->presenceMask & 
ERRORINDICATIONIES_RANAP_CN_DOMAININDICATOR_PRESENT) {
> According to specs the field is marked as "O" (optional), hence also why code 
> from ASN1 files genera […]
For reference:
25.413 Release 17, Annex A 1.1:
Rules for RANAP messages that shall contain the CN
Domain Indicator IE

Based on the principles described in TS 25.401 [3], the following rules can be 
deduced:
1) The following RANAP messages initiating a connection oriented signalling 
connection shall contain the CN
Domain Indicator IE: INITIAL UE MESSAGE message and RELOCATION REQUEST message.
2) Any RANAP message belonging to class 1 procedures and which uses 
connectionless signalling shall contain the
CN Domain Indicator IE.
3) The following RANAP messages belonging to class 2 procedures and using 
connectionless signalling shall
contain the CN Domain Indicator IE: PAGING message and ERROR INDICATION 
message, the OVERLOAD
message in DL direction (see chapter 8.25.3.1) may contain the CN Domain 
Indicator IE.



--
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/40975?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: I2a53e10c3903992a42d081e3ec300fbdb9b3c34c
Gerrit-Change-Number: 40975
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pes...@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: lynxis lazus <lyn...@fe80.eu>
Gerrit-Attention: pespin <pes...@sysmocom.de>
Gerrit-Comment-Date: Fri, 29 Aug 2025 10:07:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pes...@sysmocom.de>
Comment-In-Reply-To: lynxis lazus <lyn...@fe80.eu>

Reply via email to