Attention is currently required from: fixeria. osmith has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-dev/+/40978?usp=email )
Change subject: gen_makefile: --targets: fix subdir projects ...................................................................... Patch Set 1: (1 comment) File gen_makefile.py: https://gerrit.osmocom.org/c/osmo-dev/+/40978/comment/f6241805_702e8016?usp=email : PS1, Line 247: if "_" in project: > Wouldn't this turn `osmo_dia2gsup` into `osmo`? No, because this doesn't change `project` and because it checks if the resulting splitted string is a valid project from the `all.deps` file before attempting to placing it in the queue. With `osmo_dia2gsup` this happens: ``` project_main = "osmo" if "osmo" in project_deps: # -> False # this gets skipped # continue the same as without this change ``` -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/40978?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: I136f0d9cd982653b109005aeb35885b6f015eec8 Gerrit-Change-Number: 40978 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <[email protected]> Gerrit-CC: fixeria <[email protected]> Gerrit-Attention: fixeria <[email protected]> Gerrit-Comment-Date: Mon, 01 Sep 2025 06:38:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <[email protected]>
