Attention is currently required from: osmith. fixeria has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-msc/+/41038?usp=email )
Change subject: gsm48_cc_tx_setup_set_transaction_id: split out ...................................................................... Patch Set 1: Code-Review+1 (2 comments) File src/libmsc/gsm_04_08_cc.c: https://gerrit.osmocom.org/c/osmo-msc/+/41038/comment/14236da5_97064c19?usp=email : PS1, Line 845: TX Setup with assigned transaction. This is not allowed I find this message a bit confusing, maybe say "transaction ID is already assigned"? Not critical, can be done in a separate patch. https://gerrit.osmocom.org/c/osmo-msc/+/41038/comment/740888d2_f2d1128e?usp=email : PS1, Line 847: mncc_release_ind(trans->net, trans, trans->callref, : GSM48_CAUSE_LOC_PRN_S_LU, : GSM48_CC_CAUSE_RESOURCE_UNAVAIL); : Maybe keep this in `gsm48_cc_tx_setup()`? ``` rc = gsm48_cc_tx_setup_set_transaction_id(trans); if (rc < 0) { mncc_release_ind(trans->net, trans, trans->callref, GSM48_CAUSE_LOC_PRN_S_LU, GSM48_CC_CAUSE_RESOURCE_UNAVAIL); trans->callref = 0; goto error; } ``` -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/41038?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I715f12d09570211a98b667c56960309bd326e8d8 Gerrit-Change-Number: 41038 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osm...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanits...@sysmocom.de> Gerrit-Reviewer: pespin <pes...@sysmocom.de> Gerrit-Attention: osmith <osm...@sysmocom.de> Gerrit-Comment-Date: Thu, 04 Sep 2025 17:09:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes
