Attention is currently required from: lynxis lazus. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/41016?usp=email )
Change subject: Remove duplicate 3GPP-AAA-Server-Name definition and break 3-way circular dependency ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > unresolved this comment. I think that's something we should be doing in general for all files, ie. separating basic types from grouped AVP/messages, eg: ts29_273_types.dia ts29_273_grouped.dia But I consider this to be not strictly necessary for the already convoluted fixes to get it working for now. I don't want to spend more time than the strictly encessary one to have indirect_inherit working so we can test the feature from upstream easily. -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/41016?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: Idb1a7f7588b751c59788e4d99cd1d86f1fd2b573 Gerrit-Change-Number: 41016 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pes...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanits...@sysmocom.de> Gerrit-Reviewer: laforge <lafo...@osmocom.org> Gerrit-Reviewer: lynxis lazus <lyn...@fe80.eu> Gerrit-Attention: lynxis lazus <lyn...@fe80.eu> Gerrit-Comment-Date: Fri, 05 Sep 2025 15:17:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: lynxis lazus <lyn...@fe80.eu>
